Add support to visually represent addresses and hashes with 'blo' #44

Archethect · 2025-03-26T10:18:23Z

As requested in #14, this PR leverages the same library for representing EVM addresses as used in the Safe UI.

I also added support to visually represent the hashes in the same way. Feel free to tell me if you'd like to have this removed if you don't like it @josepchetrit12, @xaler5

github-actions · 2025-03-26T10:18:46Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Archethect · 2025-03-26T10:21:39Z

I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement

josepchetrit12 · 2025-03-26T11:36:26Z

Great! Awesome work! Since Safe doesn't use this pixel for hashes, I'd prefer to remove it. Besides, in theory, this library was created for addresses.

I thought maybe there could be a collision, but I tested it and it didn't:

const address = "0x111CEEee040739fD91D29C34C33E6B3E112F2177"
const hash32 = "0x000000000000000000111CEEee040739fD91D29C34C33E6B3E112F2177"

I think I'd also reduce the size of the pixel

josepchetrit12 · 2025-03-26T11:41:27Z

Maybe we also want to round the corners like in safe, what do you think?

Archethect · 2025-03-26T11:54:45Z

Great! Awesome work! Since Safe doesn't use this pixel for hashes, I'd prefer to remove it. Besides, in theory, this library was created for addresses.

I thought maybe there could be a collision, but I tested it and it didn't:
const address = "0x111CEEee040739fD91D29C34C33E6B3E112F2177"
const hash32 = "0x000000000000000000111CEEee040739fD91D29C34C33E6B3E112F2177"

Gotcha. I also checked this, and it just expects any string starting with '0x', therefore both hashes and addresses work.
I'll remove it for hashes.

Maybe we also want to round the corners like in safe, what do you think?

Yes, certainly doable! Regarding the size, let's see what is still visible.

Archethect · 2025-03-26T12:04:40Z

ok @josepchetrit12 ,

Tell me what you like:

30 px:

25 px:

20 px:

josepchetrit12 · 2025-03-26T18:47:47Z

20px it's the way to go, network image and pixel avatar should be the same size and style!

Archethect · 2025-03-26T19:12:28Z

ok cool! Change is committed.

app/components/pixel-avatar.tsx

app/components/transaction/AdvancedParamsStep.tsx

josepchetrit12

LGTM! Amazing thanks for your contribution!

ferrabled

LGTM! Thanks for the changes. Just one small note: there are conflicts in package-lock.json with the main branch (a dependency that it is not being used). We should regenerate the lock file to clean up any unused dependencies to maintain the dependency tree clean and consistent.

app/package-lock.json

Signed-off-by: Fernando Rabasco Ledesma <[email protected]>

josepchetrit12

LGTM!

josepchetrit12 · 2025-05-06T14:16:59Z

@Archethect Can you sign your commits? so we can merge this PR! thanks

Archethect · 2025-05-06T23:22:10Z

@Archethect Can you sign your commits? so we can merge this PR! thanks

Verified/Signed my last noop commit.
Let me know if this is good to go, or you need me to sign all my previous commits as well.
I think if I do that, all other commits will need new signatures because of the rebase though.

josepchetrit12 · 2025-05-07T11:05:19Z

@Archethect Can you sign your commits? so we can merge this PR! thanks

Verified/Signed my last noop commit. Let me know if this is good to go, or you need me to sign all my previous commits as well. I think if I do that, all other commits will need new signatures because of the rebase though.

We need all the commits signed. @Archethect

Bumps [next](https://github.com/vercel/next.js) from 14.2.25 to 14.2.26. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.2.25...v14.2.26) --- updated-dependencies: - dependency-name: next dependency-version: 14.2.26 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Archethect · 2025-05-07T13:12:25Z

@Archethect Can you sign your commits? so we can merge this PR! thanks

Verified/Signed my last noop commit. Let me know if this is good to go, or you need me to sign all my previous commits as well. I think if I do that, all other commits will need new signatures because of the rebase though.

We need all the commits signed. @Archethect

@ferrabled @josepchetrit12 I rebased and signed all my commits. Let me know if anything else is required. 🙏

josepchetrit12

LGTM!

ferrabled

LGTM! Thank you for this feature 🚀

josepchetrit12 · 2025-05-08T13:28:51Z

these commits are still not verified :(

@Archethect

Archethect · 2025-05-08T15:13:02Z

these commits are still not verified :(

@Archethect

Afaik you can't verify existing commits. The only options I see are a rebase (which I did, which recommits all previous commits signed. However, because they take the commit history into account, they are new ones) or a totally new PR from scratch discarding all commits in this PR.

josepchetrit12 · 2025-05-08T15:23:02Z

Does it work that?

git rebase -i <commit-hash-before-the-first-unsigned-commit> --exec "git commit --amend --no-edit -S"

The other option I see is creating a new PR...

Archethect · 2025-05-08T15:35:57Z

Does it work that?

git rebase -i <commit-hash-before-the-first-unsigned-commit> --exec "git commit --amend --no-edit -S"

The other option I see is creating a new PR...

Yep, thats what I did.
I will create a new PR for it in that case.

josepchetrit12 · 2025-05-08T15:38:50Z

Does it work that?
git rebase -i <commit-hash-before-the-first-unsigned-commit> --exec "git commit --amend --no-edit -S"
The other option I see is creating a new PR...

Yep, thats what I did. I will create a new PR for it in that case.

sounds good, let's create a new PR, sorry for that.

Archethect · 2025-05-09T08:23:00Z

Does it work that?
git rebase -i <commit-hash-before-the-first-unsigned-commit> --exec "git commit --amend --no-edit -S"
The other option I see is creating a new PR...

Yep, thats what I did. I will create a new PR for it in that case.

sounds good, let's create a new PR, sorry for that.

PR created here: #50

josepchetrit12 · 2025-05-09T09:52:05Z

Closing this one because we already merged this #50

Archethect added 4 commits February 27, 2025 10:54

add support to visually represent hashes to ease hash comparison.

d7d58ea

update package-lock

4286c0c

sync head

04b5d6c

add blo support for addresses and hashes

045a1f8

use single quotes

a88dfde

remove hash avatars + change pixel size to 20

258c9b6

josepchetrit12 reviewed Mar 27, 2025

View reviewed changes

app/components/pixel-avatar.tsx Outdated Show resolved Hide resolved

change hexValue to address

6f0555e

josepchetrit12 reviewed Mar 27, 2025

View reviewed changes

app/components/transaction/AdvancedParamsStep.tsx Outdated Show resolved Hide resolved

change hexValue to address on PixelAvatar uses

fc0032a

josepchetrit12 previously approved these changes Mar 27, 2025

View reviewed changes

josepchetrit12 requested a review from xaler5 March 27, 2025 08:27

ferrabled reviewed May 6, 2025

View reviewed changes

app/package-lock.json Outdated Show resolved Hide resolved

Merge branch 'main' into main

5336509

Signed-off-by: Fernando Rabasco Ledesma <[email protected]>

ferrabled dismissed josepchetrit12’s stale review via 5336509 May 6, 2025 13:22

ferrabled previously approved these changes May 6, 2025

View reviewed changes

josepchetrit12 previously approved these changes May 6, 2025

View reviewed changes

sign commit

1b3d4fe

add support to visually represent hashes to ease hash comparison.

45590fc

josepchetrit12 and others added 14 commits May 7, 2025 14:55

update the packages (OpenZeppelin#38)

549ee1e

add more networks (OpenZeppelin#40)

8913394

fix: PR Sign Comment (OpenZeppelin#42)

c5b285c

fix: Condition messaging (OpenZeppelin#43)

8995e1c

add blo support for addresses and hashes

1508d76

use single quotes

79d92dc

remove hash avatars + change pixel size to 20

9f06c4a

change hexValue to address

91fd2a2

change hexValue to address on PixelAvatar uses

2bc56f4

fix: Use aws credentials actions (OpenZeppelin#45)

78ba14b

Fix OpenZeppelin#41 change hash ordering (OpenZeppelin#48)

1eb1b6f

sign commit

67fe849

Merge branch 'main' of github.com:Archethect/safe-utils

8e0af32

Archethect dismissed stale reviews from josepchetrit12 and ferrabled via 8e0af32 May 7, 2025 13:07

remove blockies from package lock

5cba054

josepchetrit12 approved these changes May 7, 2025

View reviewed changes

ferrabled approved these changes May 8, 2025

View reviewed changes

Archethect mentioned this pull request May 9, 2025

add support to visually represent addresses #50

Merged

josepchetrit12 closed this May 9, 2025

github-actions bot locked and limited conversation to collaborators May 9, 2025

Add support to visually represent addresses and hashes with 'blo' #44

Add support to visually represent addresses and hashes with 'blo' #44

Uh oh!

Conversation

Archethect commented Mar 26, 2025

Uh oh!

github-actions bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Archethect commented Mar 26, 2025

Uh oh!

josepchetrit12 commented Mar 26, 2025

Uh oh!

josepchetrit12 commented Mar 26, 2025

Uh oh!

Archethect commented Mar 26, 2025

Uh oh!

Archethect commented Mar 26, 2025

Uh oh!

josepchetrit12 commented Mar 26, 2025

Uh oh!

Archethect commented Mar 26, 2025

Uh oh!

Uh oh!

Uh oh!

josepchetrit12 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ferrabled left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

josepchetrit12 left a comment

Choose a reason for hiding this comment

Uh oh!

josepchetrit12 commented May 6, 2025

Uh oh!

Archethect commented May 6, 2025

Uh oh!

josepchetrit12 commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Archethect commented May 7, 2025

Uh oh!

josepchetrit12 left a comment

Choose a reason for hiding this comment

Uh oh!

ferrabled left a comment

Choose a reason for hiding this comment

Uh oh!

josepchetrit12 commented May 8, 2025

Uh oh!

Archethect commented May 8, 2025

Uh oh!

josepchetrit12 commented May 8, 2025

Uh oh!

Archethect commented May 8, 2025

Uh oh!

josepchetrit12 commented May 8, 2025

Uh oh!

Archethect commented May 9, 2025

Uh oh!

josepchetrit12 commented May 9, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 26, 2025 •

edited

Loading

josepchetrit12 left a comment •

edited

Loading

josepchetrit12 commented May 7, 2025 •

edited

Loading